I searched for a solution on this and found quite a few instances where people ended up with duplicate identities after a domain migration. That's not the situation I am in but it is somewhat similar. A few months ago all of the users in the domain that we use for TFS got deleted and then re-created. Of course they now have new SIDs since they are new users. Everything is working fine except when users submit a code review, they get the following warning:
"Some of the reviewers don't have permission to some of the files to review. Do you want to submit the code review anyway?"
They are able to click continue and the code review functionality works fine. This is the only clue I had that something was out of the ordinary but I took a look at the tbl_Identity and I see that all the users that were in TFS when the account deletion happened now have two identities with different SIDs. I can see the ones that are correct but I don't know of any way to get rid of the incorrect ones. It would be easy enough to just delete those rows but I don't want to monkey with it and potentially break something. Is there anything I can do to get them cleaned up?